Migrate deprecated APIs#2127
Closed
thatgato wants to merge 2 commits into
Closed
Conversation
Migrated spawn() usage to use task.spawn() instead, as spawn() is deprecated. Migration was skipped on UI windows, namely: Window.rbxmx Hint.rbxmx Notification.rbxmx Output.rbxmx
Migrated the usage of wait() to task.wait(), since wait() has been deprecated. UI model code has not been migrated (for example Aero/PlayerList.rbxmx BasicAdmin/Message.rbxmx, etc.)
Contributor
|
There's not really a point in 'migrating' them since the client & server already change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated
spawn()andwait()to instead usetask.spawn()andtask.wait()respectively.Some UI related
.rbxmxmodels have been skipped, I didn't want to touch those, however I can migrate those aswell, if needed